Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paper-tabs): converts to a glimmer component. #1313

Open
wants to merge 3 commits into
base: feature/glimmer-paper-switch
Choose a base branch
from

Conversation

Copy link

@hero-davidm hero-davidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like javascript to me

addon/components/paper-tabs.js Outdated Show resolved Hide resolved
addon/components/paper-tabs.js Outdated Show resolved Hide resolved
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-tabs branch 2 times, most recently from c54cf06 to 4a36e12 Compare December 5, 2024 00:44
@matthewhartstonge matthewhartstonge marked this pull request as ready for review December 5, 2024 03:38
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-input branch from 3826ad3 to 9ed977b Compare December 5, 2024 23:47
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-tabs branch from 4a36e12 to 48fb263 Compare December 5, 2024 23:47
@matthewhartstonge matthewhartstonge changed the base branch from feature/glimmer-paper-input to feature/glimmer-paper-switch December 17, 2024 03:27
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-tabs branch from 48fb263 to 71fcab7 Compare December 17, 2024 03:27
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-switch branch from 78c3c36 to 243c885 Compare December 30, 2024 10:50
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-tabs branch from 71fcab7 to ce40958 Compare December 30, 2024 11:03
Copy link

github-actions bot commented Dec 30, 2024

Some tests with 'continue-on-error: true' have failed:

Copy link

Some tests with 'continue-on-error: true' have failed:

  • ember-release-no-deprecations

Created by continue-on-error-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants