-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paper-tabs): converts to a glimmer component. #1313
Open
matthewhartstonge
wants to merge
3
commits into
feature/glimmer-paper-switch
Choose a base branch
from
feature/glimmer-paper-tabs
base: feature/glimmer-paper-switch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(paper-tabs): converts to a glimmer component. #1313
matthewhartstonge
wants to merge
3
commits into
feature/glimmer-paper-switch
from
feature/glimmer-paper-tabs
+585
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthewhartstonge
commented
Dec 4, 2024
- feat(addon/components/paper-ink-bar): converts to a glimmer component.
- feat(addon/components/paper-tab): converts to a glimmer component.
- feat(addon/components/paper-tabs): converts to a glimmer component.
hero-davidm
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like javascript to me
matthewhartstonge
force-pushed
the
feature/glimmer-paper-tabs
branch
2 times, most recently
from
December 5, 2024 00:44
c54cf06
to
4a36e12
Compare
20 tasks
matthewhartstonge
force-pushed
the
feature/glimmer-paper-input
branch
from
December 5, 2024 23:47
3826ad3
to
9ed977b
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-tabs
branch
from
December 5, 2024 23:47
4a36e12
to
48fb263
Compare
matthewhartstonge
changed the base branch from
feature/glimmer-paper-input
to
feature/glimmer-paper-switch
December 17, 2024 03:27
matthewhartstonge
force-pushed
the
feature/glimmer-paper-tabs
branch
from
December 17, 2024 03:27
48fb263
to
71fcab7
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-switch
branch
from
December 30, 2024 10:50
78c3c36
to
243c885
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-tabs
branch
from
December 30, 2024 11:03
71fcab7
to
ce40958
Compare
Some tests with 'continue-on-error: true' have failed:
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.